Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential NULL pointer dereference in dsl_dataset_promote_check() #13967

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Fix potential NULL pointer dereference in dsl_dataset_promote_check() #13967

merged 1 commit into from
Sep 30, 2022

Conversation

ryao
Copy link
Contributor

@ryao ryao commented Sep 28, 2022

Motivation and Context

If the list_head() returns NULL, we dereference it, right before we check to see if it returned NULL.

Coverity complained about this.

Description

We have defined two different pointers that both point to the same thing, which are origin_head and origin_ds. Almost everything uses origin_ds, so we switch them to use origin_ds.

We also promote origin_ds to a const pointer so that the compiler verifies that nothing modifies it.

How Has This Been Tested?

A build test was done locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ryao
Fix potential NULL pointer dereference in dsl_dataset_promote_check()
87fd23e 
If the `list_head()` returns NULL, we dereference it, right before we
check to see if it returned NULL.

We have defined two different pointers that both point to the same
thing, which are `origin_head` and `origin_ds`. Almost everything uses
`origin_ds`, so we switch them to use `origin_ds`.

We also promote `origin_ds` to a const pointer so that the compiler
verifies that nothing modifies it.

Coverity complained about this.

Signed-off-by: Richard Yao <[email protected]>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Sep 28, 2022
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Sep 30, 2022
@behlendorf behlendorf merged commit a36b37d into openzfs:master Sep 30, 2022
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 2, 2022
@ryao @andrewc12
Fix potential NULL pointer dereference in dsl_dataset_promote_check()
0e0e8f6 
If the `list_head()` returns NULL, we dereference it, right before we
check to see if it returned NULL.

We have defined two different pointers that both point to the same
thing, which are `origin_head` and `origin_ds`. Almost everything uses
`origin_ds`, so we switch them to use `origin_ds`.

We also promote `origin_ds` to a const pointer so that the compiler
verifies that nothing modifies it.

Coverity complained about this.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13967
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 2, 2022
@ryao @andrewc12
Fix potential NULL pointer dereference in dsl_dataset_promote_check()
34d5b70 
If the `list_head()` returns NULL, we dereference it, right before we
check to see if it returned NULL.

We have defined two different pointers that both point to the same
thing, which are `origin_head` and `origin_ds`. Almost everything uses
`origin_ds`, so we switch them to use `origin_ds`.

We also promote `origin_ds` to a const pointer so that the compiler
verifies that nothing modifies it.

Coverity complained about this.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13967
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 6, 2022
@ryao @andrewc12
Fix potential NULL pointer dereference in dsl_dataset_promote_check()
a73bf28 
If the `list_head()` returns NULL, we dereference it, right before we
check to see if it returned NULL.

We have defined two different pointers that both point to the same
thing, which are `origin_head` and `origin_ds`. Almost everything uses
`origin_ds`, so we switch them to use `origin_ds`.

We also promote `origin_ds` to a const pointer so that the compiler
verifies that nothing modifies it.

Coverity complained about this.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13967
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Oct 6, 2022
@ryao @andrewc12
Fix potential NULL pointer dereference in dsl_dataset_promote_check()
994ae0f 
If the `list_head()` returns NULL, we dereference it, right before we
check to see if it returned NULL.

We have defined two different pointers that both point to the same
thing, which are `origin_head` and `origin_ds`. Almost everything uses
`origin_ds`, so we switch them to use `origin_ds`.

We also promote `origin_ds` to a const pointer so that the compiler
verifies that nothing modifies it.

Coverity complained about this.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13967
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 23, 2022
@ryao @tonyhutter
Fix potential NULL pointer dereference in dsl_dataset_promote_check()
71533e4 
If the `list_head()` returns NULL, we dereference it, right before we
check to see if it returned NULL.

We have defined two different pointers that both point to the same
thing, which are `origin_head` and `origin_ds`. Almost everything uses
`origin_ds`, so we switch them to use `origin_ds`.

We also promote `origin_ds` to a const pointer so that the compiler
verifies that nothing modifies it.

Coverity complained about this.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13967
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Nov 30, 2022
@ryao @tonyhutter
Fix potential NULL pointer dereference in dsl_dataset_promote_check()
537c11e 
If the `list_head()` returns NULL, we dereference it, right before we
check to see if it returned NULL.

We have defined two different pointers that both point to the same
thing, which are `origin_head` and `origin_ds`. Almost everything uses
`origin_ds`, so we switch them to use `origin_ds`.

We also promote `origin_ds` to a const pointer so that the compiler
verifies that nothing modifies it.

Coverity complained about this.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13967
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 1, 2022
@ryao @tonyhutter
Fix potential NULL pointer dereference in dsl_dataset_promote_check()
c562bbe 
If the `list_head()` returns NULL, we dereference it, right before we
check to see if it returned NULL.

We have defined two different pointers that both point to the same
thing, which are `origin_head` and `origin_ds`. Almost everything uses
`origin_ds`, so we switch them to use `origin_ds`.

We also promote `origin_ds` to a const pointer so that the compiler
verifies that nothing modifies it.

Coverity complained about this.

Reviewed-by: Brian Behlendorf <[email protected]>
Reviewed-by: Neal Gompa <[email protected]>
Signed-off-by: Richard Yao <[email protected]>
Closes openzfs#13967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@Conan-Kudo Conan-Kudo Conan-Kudo approved these changes

@pcd1193182 pcd1193182 Awaiting requested review from pcd1193182

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryao @behlendorf @Conan-Kudo